issue_comments: 155882953

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/655#issuecomment-155882953 https://api.github.com/repos/pydata/xarray/issues/655 155882953 MDEyOklzc3VlQ29tbWVudDE1NTg4Mjk1Mw== 2443309 2015-11-11T19:16:20Z 2015-11-11T19:16:20Z MEMBER

I'll just chime in here quickly and layout how I think this should go - 1. If you set anything, it should not be overwritten. This includes the colormap and vmin/vmax. 2. If you want very specific/consistent behavior, you'll need to explicitly provide those arguments. 3. The only safe times to assume a diverging colormap is when vmin = -vmax or when center is not None. If you want a diverging colormap for other situations, you need to specify cmap in the plot call.

All in all, I think what I'm getting at is we may want to tighten up on when we switch from the default cmap to the diverging cmap.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   116349205