issue_comments: 155817937

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/655#issuecomment-155817937 https://api.github.com/repos/pydata/xarray/issues/655 155817937 MDEyOklzc3VlQ29tbWVudDE1NTgxNzkzNw== 10050469 2015-11-11T15:32:29Z 2015-11-11T15:32:29Z MEMBER

@mwaskom correct. I forgot to read @shoyer 's comments about this. He said:

If only one of vmin/max is provided and the colormap is diverging, then the other should be determined by reflecting the limit around the center -- not by taking the largest distance from the center. If this results in data falling beyond the color limits, then so be it (in xray, this will be displayed with the extend argument on the colorbar). For example, suppose my data contains values between -10 and 100. If I plot it with vmin=-10 and vmax=None, then (1) we should detect diverging data with center=0 (unless center=False) and (2) we should infer vmax=10.

I agree with this, but only if center is explicitly provided. I'll try to implement this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   116349205