issue_comments: 154919901

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/642#issuecomment-154919901 https://api.github.com/repos/pydata/xarray/issues/642 154919901 MDEyOklzc3VlQ29tbWVudDE1NDkxOTkwMQ== 1217238 2015-11-09T04:44:40Z 2015-11-09T04:44:40Z MEMBER

Also, the ideal behavior really when you are plotting a diverging colormap and have provided vmin and vmax is to change the colormap itself so the breakpoint is at the data center but the limits are as provided.

Seaborn currently doesn't have any notion of "divergent" colormaps without breakpoints (beyond explicitly providing one with the cmap argument, but that doesn't trigger the divergent colormap logic currently). To be honest, I'm not sure there's a use case for that -- the only place where I would want to default a breakpoint is around zero, which is straightforward enough to signal with center=0.

For some reason I thought that was an implementation detail, although I'm having trouble pulling up a reference. Seems weird to test is False.

I agree it's weird and usually a code smell. But I have seen it used in a number of places, especially when it's useful to distinguish a boolean from a default value. For example, you can find it in both the numpy and pandas code bases: https://github.com/numpy/numpy/search?l=python&q=%22is+False%22&type=Code&utf8=%E2%9C%93 https://github.com/pydata/pandas/search?l=python&q=%22is+False%22&type=Code&utf8=%E2%9C%93

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   114576415