home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1526489103

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7764#issuecomment-1526489103 https://api.github.com/repos/pydata/xarray/issues/7764 1526489103 IC_kwDOAMm_X85a_GAP 1217238 2023-04-27T21:15:23Z 2023-04-27T21:15:23Z MEMBER

Allowing for explicitly passing a function matching the einsum interface is certainly more flexible than a boolean or enum argument, so @TomNicholas's suggestion of einsum_func=np.einsum is the version I would suggest.

The overhead from optimizing contraction paths is probably very small relative to the overhead of Xarray in general, so I would support setting optimize=True by default in Xarray, and/or using opt-einsum automatically if it is installed. JAX always use opt-einsum (opt-einsum is actually a hard dependency) and I have never heard any complaints.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1672288892
Powered by Datasette · Queries took 0.871ms · About: xarray-datasette