home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1492880874

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7654#issuecomment-1492880874 https://api.github.com/repos/pydata/xarray/issues/7654 1492880874 IC_kwDOAMm_X85Y-43q 5821660 2023-04-01T08:46:49Z 2023-04-01T09:28:16Z MEMBER

@dcherian @Illviljan Thanks for the first round of review. I've rebased everything on latest main. Now the code moving from conventions.py to coding.variable.py is correct. I've also removed the functions which have been converted to VariableCoders and adapted the tests.

To sum up this PR, it does:

  • convert functions to VariableCoders along @shoyer's TODO: https://github.com/pydata/xarray/blob/1c81162755457b3f4dc1f551f0321c75ec9daf6c/xarray/conventions.py#L298-L302 https://github.com/pydata/xarray/blob/1c81162755457b3f4dc1f551f0321c75ec9daf6c/xarray/conventions.py#L393-L405
  • preserve boolean dtype within encoding: https://github.com/pydata/xarray/issues/7652#issuecomment-1476956975
  • deterrmine cf packed dtype from scale_factor/add_offset

7691, #2304

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1633623916
Powered by Datasette · Queries took 0.682ms · About: xarray-datasette