home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1477155245

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7638#issuecomment-1477155245 https://api.github.com/repos/pydata/xarray/issues/7638 1477155245 IC_kwDOAMm_X85YC5mt 97012127 2023-03-21T01:17:04Z 2023-03-21T01:17:04Z CONTRIBUTOR

Hi @harshitha1201 - thanks for working on this!

Is there are reason why you made a second pull request here rather than continuing with #7604? Generally we try to push more commits to the same branch, so as to keep a record of reviewer's feedback all in one place.

I've added a couple more suggestions anyway.

I was unable to commit, so I created another PR. This won't happen again.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1627983028
Powered by Datasette · Queries took 0.989ms · About: xarray-datasette