home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1466134208

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7619#issuecomment-1466134208 https://api.github.com/repos/pydata/xarray/issues/7619 1466134208 IC_kwDOAMm_X85XY27A 14808389 2023-03-13T13:20:15Z 2023-03-13T13:20:15Z MEMBER

this looks good to me, but we'd need some tests to make sure we don't reintroduce this issue. I'd probably extend the "simple" case of xarray/tests/test_computation.py::test_polyval by creating two versions: one with int32 values for degree and one with int64 values

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1621385466
Powered by Datasette · Queries took 0.476ms · About: xarray-datasette