home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 145211537

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/605#issuecomment-145211537 https://api.github.com/repos/pydata/xarray/issues/605 145211537 MDEyOklzc3VlQ29tbWVudDE0NTIxMTUzNw== 2443309 2015-10-03T07:24:04Z 2015-10-03T07:24:04Z MEMBER

@shoyer - the idea of the coordinates convention is that we all ready know the x/y coordinate names. So we shouldn't need to supply them like this: ds.T.plot.contourf('lat', 'lon'). I'm thinking it would be better to store the coord names coming from https://github.com/xray/xray/blob/master/xray/conventions.py#L882 in each DataArray. Maybe a DataArray.coord_keys = ('xc', 'yc') attribute is in order? Currently, we aren't really using the coordinates attribute in its intended way.

In the plotting logic, we should just search to see if coord_keys is not None before passing the coordinates to the plotting method.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  109589162
Powered by Datasette · Queries took 0.718ms · About: xarray-datasette