issue_comments: 1449013427

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3980#issuecomment-1449013427 https://api.github.com/repos/pydata/xarray/issues/3980 1449013427 IC_kwDOAMm_X85WXjCz 43316012 2023-02-28T22:24:56Z 2023-02-28T22:24:56Z COLLABORATOR

I will not be able to join tomorrow, so here are my thoughts on this topic:

  • How to work with subclassed Datasets that should return DataArrays? I think the pandas approach is good, we add Dataset.dataarray_cls = DataArray and DataArray.dataset_cls = Dataset which subclasses can overwrite.
  • How to deal with subclasses that change the constructor aka. __init__? Probably we need to introduce a kind of shortcut constructor that will be called instead in functions that create new instances (right now the subclass needs the same constructor signature as xarrays version). But then custom instance attributes will not be set etc. Not sure what is the best approach here.
  • Is the whole thing limited to DataArrays and Datasets or can one also subclass Variables?
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   602218021