home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 144214269

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/593#issuecomment-144214269 https://api.github.com/repos/pydata/xarray/issues/593 144214269 MDEyOklzc3VlQ29tbWVudDE0NDIxNDI2OQ== 2443309 2015-09-29T22:54:13Z 2015-09-30T00:07:14Z MEMBER

I'm going to argue that it is better to raise an error at the time of offense. Currently we are failing silently, and yielding objects that are unusable. The logic I'm envisioning is like this:

Python if not issorted(indexer) and not self.loaded: raise IndexError('...')

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  108769226
Powered by Datasette · Queries took 0.599ms · About: xarray-datasette