home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1427503304

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7463#issuecomment-1427503304 https://api.github.com/repos/pydata/xarray/issues/7463 1427503304 IC_kwDOAMm_X85VFfjI 118520620 2023-02-13T08:02:55Z 2023-02-13T08:02:55Z NONE

Yes I think we should, but I might have missed the rationale behind allowing it if this is intentional.

EDIT: perhaps better to issue a warning first to avoid some breaking change. We could also try to fix it (make a deep copy) at the same time as deprecating it, but that might be tricky without again introducing performance regressions.

I would assume that deepcopy are completely going to copy the object, so if I change internal parts (like coordinates here), 1st object shall not change. It definitely affects the performance, but otherwise deepcopy is not deep anymore

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1550792876
Powered by Datasette · Queries took 0.69ms · About: xarray-datasette