issue_comments: 1384130795

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7391#issuecomment-1384130795 https://api.github.com/repos/pydata/xarray/issues/7391 1384130795 IC_kwDOAMm_X85SgCjr 7316393 2023-01-16T14:16:27Z 2023-01-16T14:16:56Z CONTRIBUTOR

Hit a roadblock.

For binary ops the only way to set keep_attrs is through the options. However we can not set combine_attrs style strings to it due to strict validation. So this would lead to an error: python with xr.set_options(keep_attrs="drop_conflicts"): ds1 + ds2

To cricle around this we could let keep_attrs passed in the operator methods so user could do: python ds1.__add__(ds2, keep_attrs="drop_conflicts") But this isn't "nice".

Or perhaps I missed something? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1503573351