home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1383112964

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7439#issuecomment-1383112964 https://api.github.com/repos/pydata/xarray/issues/7439 1383112964 IC_kwDOAMm_X85ScKEE 14371165 2023-01-15T10:24:55Z 2023-01-15T10:31:29Z MEMBER

I've found this part of the documentation a bit scary in the past because there is so much stuff to do for a simple "typo fix" so I welcome changes here!

Nowadays, since the CI runs pytest, ASV performance benchmarks, pre-commit and builds the documentation on every PR it isn't really necessary for new contributors to get it to run locally. The only thing left is setting up a new branch with git, change the code and create a PR. If the CI fails check the details of that test, correct the code, push a new commit. Setting up git can also be scary for new users but then there is github desktop which hides away all of that in a quite user friendly GUI.

Sure, if you're doing bigger changes running the specific tests locally is probably faster but at that point you're probably a more experienced contributor anyway.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1532853152
Powered by Datasette · Queries took 0.592ms · About: xarray-datasette