issue_comments: 1378579381

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7391#issuecomment-1378579381 https://api.github.com/repos/pydata/xarray/issues/7391 1378579381 IC_kwDOAMm_X85SK3O1 7316393 2023-01-11T11:03:40Z 2023-01-11T11:03:40Z CONTRIBUTOR

Thanks for your suggestions @keewis!

If possible I'd like to change the computation of the attrs of the result a bit to allow more than just bool values (see below).

I was puzzled initially. We would introduce the combine_attrs behaviour of xarray.merge() but under keep_attrs. Then I found out this is already a thing in apply_ufunc().

I like the idea, shouldn't we - implement this for xarray.Variable too? - consider this as new feature, not just a bugfix? (for describing in whats-new.rst) - describe in the documentation? (also for apply_ufunc() - it's not yet described there).

could do all these, let me know

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1503573351