issue_comments: 1374674007
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/7400#issuecomment-1374674007 | https://api.github.com/repos/pydata/xarray/issues/7400 | 1374674007 | IC_kwDOAMm_X85R79xX | 775186 | 2023-01-08T00:54:31Z | 2023-01-08T00:54:31Z | CONTRIBUTOR | Hi, thanks for doing this @kmuehlbauer . FWIW I'm no longer seeing the issue I was previously seeing when I submitted https://github.com/pydata/xarray/pull/3545 when I just run with released xarray v2022.12.0 (I haven't gone back further to see when the issue started going away so I'm not really sure if the old error has just been suppressed or if the single case I was seeing back then was resolved in a previous PR--or there is also a chance there is something which changed in my data over that long time period). That being said I also applied this PR to my workflow and reran the concat code and it continues to pass correctly with this PR from what I've seen so far. @kmuehlbauer did you see the tests I created here? https://github.com/pydata/xarray/blob/03f9b3b85aee039f47dd693322492ab09f57fb73/xarray/tests/test_concat.py Not all of them got to a passing state but there were several cases I tried to document with the tests there. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1508009922 |