issue_comments: 136552408
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/538#issuecomment-136552408 | https://api.github.com/repos/pydata/xarray/issues/538 | 136552408 | MDEyOklzc3VlQ29tbWVudDEzNjU1MjQwOA== | 1197350 | 2015-09-01T02:10:51Z | 2015-09-01T02:10:51Z | MEMBER | @jhamman One nice thing about this current PR is that it does allow people without seaborn to still use a custom list of colors. If we don't want to make seaborn a dependency, then surely that is a good thing. The only thing seaborn is now needed for is its special named palettes. As for the named palettes, I don't think a new keyword is needed. This has been a good learning experience for me. (Had never touched seaborn before.) But I probably won't work on this PR any more. Bottom line, it does fix the original issue without breaking anything. It also improves the testing of colors. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
101719623 |