home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1339452942

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7356#issuecomment-1339452942 https://api.github.com/repos/pydata/xarray/issues/7356 1339452942 IC_kwDOAMm_X85P1m4O 90008 2022-12-06T14:14:57Z 2022-12-06T14:14:57Z CONTRIBUTOR

No explicit test was added to ensure that the data wasn't loaded. I just experienced this bug enough (we would accidentally load 100GB files in our code base) that I knew exactly how to fix it.

If you want i can add a test to ensure that future optimizations to nbytes do not trigger a data load.

I was hoping the 1 line fix would be a shoe in.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1475567394
Powered by Datasette · Queries took 0.694ms · About: xarray-datasette