home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1328156304

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7323#issuecomment-1328156304 https://api.github.com/repos/pydata/xarray/issues/7323 1328156304 IC_kwDOAMm_X85PKg6Q 1217238 2022-11-27T02:27:07Z 2022-11-27T02:27:07Z MEMBER

Thanks for report and the PR!

This really needs a "minimal complete verifiable" example (e.g., by creating and loading a Zarr array with random data) so others can verify your reported the performance gains: https://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports https://stackoverflow.com/help/minimal-reproducible-example

To be honest, this fix looks a little funny to me, because NumPy's own implementation of tolist() is so similar. I would love to understand what is going on.

If you can reproduce the issue only using NumPy, it could also make more sense to file this as a upstream bug report to NumPy. The NumPy maintainers are in a better position to debug tricky memory allocation issues involving NumPy.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1465047346
Powered by Datasette · Queries took 2.48ms · About: xarray-datasette