home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1327795061

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7321#issuecomment-1327795061 https://api.github.com/repos/pydata/xarray/issues/7321 1327795061 IC_kwDOAMm_X85PJIt1 14808389 2022-11-25T19:03:45Z 2022-11-28T10:36:29Z MEMBER
some context on the change yeah, that's a shame, especially since adding support for inline comments would be as easy as passing `inline_comment_prefixes=("#",)` to the `RawConfigParser` constructor. I suppose the fear was that with that the `#` character would be impossible to use in settings, which would make this a limitation of the configuration format. I think switching to a different format (`yaml`, `toml`) would have been possible, but I guess that's another can of worms. I can understand that they're doing *something*, though, because silently ignoring based on letters from what is supposed to be comments is pretty bad.

To improve on this, we might be able to move the comments to a continuous block and prefix them with the error code, then use a collapsed (comma-separated) list of codes for the actual ignores. Something like this, maybe? ini ignore = # E203: whitespace before ':' - doesn't work well with black # E402: module level import not at top of file # E501: line too long - let black worry about that # E731: do not assign a lambda expression, use a def # W50: line break before binary operator E203,E402,E501,E731,W50 The disadvantage would be that adding a new ignore changes two lines, and should we have lots of ignores the line wrapping would be a bit weird.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1464824094
Powered by Datasette · Queries took 113.867ms · About: xarray-datasette