issue_comments: 1311279880

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7272#issuecomment-1311279880 https://api.github.com/repos/pydata/xarray/issues/7272 1311279880 IC_kwDOAMm_X85OKIsI 14371165 2022-11-11T06:24:06Z 2022-11-11T06:26:40Z MEMBER
  • default markersize values of widths are 18 to 72.
  • plt.scatter default markersize is 36.
  • plt.plot default linewidth is 6.

With the current version of the PR we would get 18 for 1-sized arrays, but 36 if markersize was undefined. This seems a bit inconsistent to me. I think we should default to 36 instead for 1-sized arrays, but this would require a bit more tweaks than the scope of the current PR.

I think we'll merge this to fix the zero division -> np.nan -> empty plots. And then I'll come up with a another PR where the size is the same.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1440711212