home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1295881068

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7209#issuecomment-1295881068 https://api.github.com/repos/pydata/xarray/issues/7209 1295881068 IC_kwDOAMm_X85NPZNs 43316012 2022-10-29T15:56:23Z 2022-10-29T15:56:23Z COLLABORATOR

Thanks @headtr1ck do we have a benchmark for this, if not can we add one please?

Since the benchmark didn't change we either don't have one or my change doesn't matter much, haha.

I think the most important change is the shallow copy for Variable.to_index_variable, but I will have to check how to test this in a useful way, probably better testing some functions that use it indirectly.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1421441672
Powered by Datasette · Queries took 0.844ms · About: xarray-datasette