home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 129285729

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/468#issuecomment-129285729 https://api.github.com/repos/pydata/xarray/issues/468 129285729 MDEyOklzc3VlQ29tbWVudDEyOTI4NTcyOQ== 2443309 2015-08-10T03:00:50Z 2015-08-10T03:00:50Z MEMBER

Ah, yes. Open a new PR. You must have pushed your rebased master to your fork.

In general, I never edit on my fork's master branch. My typical workflow is to create separate feature branches off the xray/xray:master branch:

``` bash git checkout master git pull upstream master git checkout -b feature/my_feature

...edit...

git add edited_files* git commit ... git push origin feature/my_feature

create pull request from my fork's feature/my_feature to xray:master on github

```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  94508580
Powered by Datasette · Queries took 83.808ms · About: xarray-datasette