issue_comments: 1292687484

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7228#issuecomment-1292687484 https://api.github.com/repos/pydata/xarray/issues/7228 1292687484 IC_kwDOAMm_X85NDNh8 43316012 2022-10-26T21:44:39Z 2022-10-26T21:55:07Z COLLABORATOR

In the line plot we now have: python if ndims == 0 or darray.size == 0: # TypeError to be consistent with pandas raise TypeError("No numeric data to plot.") if ndims > 2: raise ValueError( "Line plots are for 1- or 2-dimensional DataArrays. " "Passed DataArray has {ndims} " "dimensions".format(ndims=ndims) ) which looks just wrong, haha.

See https://github.com/pydata/xarray/issues/7156#issuecomment-1277103850

Should we change the error for ndims > 2 to a TypeError as well? That would be a breaking change (I don't think it would affect many people though...)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1424707135