issue_comments: 1291391647

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7222#issuecomment-1291391647 https://api.github.com/repos/pydata/xarray/issues/7222 1291391647 IC_kwDOAMm_X85M-RKf 90008 2022-10-26T02:03:41Z 2022-10-26T02:03:41Z CONTRIBUTOR

The reason this is a separate merge request, is that I agree that this is more contentious as a change.

However, I will argue that Aligner should really not be a class.

Using ripgrep you find that the only instances of Aligner exist internally: ` xarray/core/dataset.py 2775: aligner: alignment.Aligner, 2783: """Callback called fromAligner`` to create a new reindexed Dataset."""

xarray/core/alignment.py 107:class Aligner(Generic[DataAlignable]): 114: aligner = Aligner(objects, *kwargs) <------- Example 767: aligner = Aligner( <----------- Used and consumed for the method align 881: aligner = Aligner( <----------- Used and consumed for the method reindex 909: # This check is not performed in Aligner.

xarray/core/dataarray.py 1752: aligner: alignment.Aligner, 1760: """Callback called from Aligner to create a new reindexed DataArray.""" ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1423321834