issue_comments: 129101660

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/523#issuecomment-129101660 https://api.github.com/repos/pydata/xarray/issues/523 129101660 MDEyOklzc3VlQ29tbWVudDEyOTEwMTY2MA== 2443309 2015-08-09T03:43:09Z 2015-08-09T03:43:09Z MEMBER

I have a few general comments,
1. Can you point me to where in the CF Conventions or UDUNITS the valid time coordinate units defined? 2. We should think about whether or not this fix belongs in xray or netCDF4. I am of the opinion that if the CF Conventions do in fact support the units in question, we should apply this fix in the netCDF package. If they don't, I don't think we wan to support it here either. 3. @shoyer is out for a bit but he will almost certainly want to weigh in on this.

If we end up going this route, you'll want to add some unit tests in test_conventions.py.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   99847237