issue_comments: 1290446119

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4995#issuecomment-1290446119 https://api.github.com/repos/pydata/xarray/issues/4995 1290446119 IC_kwDOAMm_X85M6qUn 24661500 2022-10-25T12:11:45Z 2022-10-25T12:11:45Z NONE

I think the original scope of this issue is still valid. I also would expect that indices that are not within the tolerance would simply be dropped. While it might be nice in some situations, I don't really think that specifying a fill value is needed in order to accomplish this.

The issue I'm facing with reindex is that it doesn't really scale as well as sel does, significantly reducing the amount of data I can handle. I would like to humbly suggest that there still might be interest in seeing this functionality.

Unfortunately the testing logs from #4996 have expired so it's not clear why the tests failed for this PR before it was closed.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   822320976