home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1290186004

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7181#issuecomment-1290186004 https://api.github.com/repos/pydata/xarray/issues/7181 1290186004 IC_kwDOAMm_X85M5q0U 1486942 2022-10-25T08:31:50Z 2022-10-25T08:31:50Z CONTRIBUTOR

But then somehow DataArray._copy is called ~500k times. So somewhere you must have some DataArrays in places where there should be none (in attrs, e.g.)

I think it has to be something like that. I'll see if I can dig into what these Datasets look like.

I'm sure we can get away with fewer deep copies here. I think it's something like we're caching generated Datasets between different test cases, but some of them need to modify them so they're deep copied. I guess previously that was fine, but maybe now it's just cheaper to make new instances from scratch.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1412895383
Powered by Datasette · Queries took 0.643ms · About: xarray-datasette