issue_comments: 127673118

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/509#issuecomment-127673118 https://api.github.com/repos/pydata/xarray/issues/509 127673118 MDEyOklzc3VlQ29tbWVudDEyNzY3MzExOA== 2443309 2015-08-04T16:51:59Z 2015-08-05T17:24:21Z MEMBER

This looks good. Thanks for doing that.

Are there any cases where you would want to set vmin/vmax to something other than the first and last levels?

Yes, but they are rare and you could pass in a custom norm in those cases.

This assuredly still needs more tests -- mostly to verify that every plot types ends up with consistent levels.

I'll think a bit more about how to test these aspects.

There are three things left to do here (this has gotten a big bigger than I was expecting): - [x] Decide what to do with seaborn's handling of jet - [x] Fill in tests - [x] Add an example in the plot docs

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   98629509