home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1276433539

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6795#issuecomment-1276433539 https://api.github.com/repos/pydata/xarray/issues/6795 1276433539 IC_kwDOAMm_X85MFNSD 4160723 2022-10-12T16:19:34Z 2022-10-12T16:19:34Z MEMBER

Looks good to me @keewis. Thanks for your work on the indexes repr!

Yes I think we can skip displaying default indexes for now... The question is which indexes are considered as default, i.e., all PandasIndex and PandasMultiIndex instances (like in this PR) or just the single pandas indexes automatically created for the dimension coordinates? We can decide this later, though, it's not a problem adding more indexes in the text repr later (we'll probably need it when dropping the multi-index dimension coordinate with tuple elements). For the html repr it's easier: we could display all indexes and collapse the section by default.

but I thought "dimension coordinates" (and in particular their indexes) are still used for alignment?

Yes that's a good point. Let's keep "dimensions without coordinates".

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1306887842
Powered by Datasette · Queries took 0.979ms · About: xarray-datasette