issue_comments: 1275094649

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7153#issuecomment-1275094649 https://api.github.com/repos/pydata/xarray/issues/7153 1275094649 IC_kwDOAMm_X85MAGZ5 5635139 2022-10-11T18:17:21Z 2022-10-11T18:17:21Z MEMBER

Unless you meant that black should be installed together with blackdoc? If that was the question: it already is, but will only be updated together with blackdoc, so now that I think of it that might actually make pinning in blackdoc redundant?

Without pinning black in additional_dependencies, which version is used? I think the issue might be that the latest version is used based on when it's installed. But that means that different people will have different versions. And so if we pin it within blackdoc, then people can't upgrade black without a new release of blackdoc. And so we're in this spot where each user needs to pin it within their .pre-commit-config.yaml.

Does pre-commit support additional_dependencies defined by the hook? I couldn't find it in https://pre-commit.com/#creating-new-hooks. That would solve this.

Otherwise I guess you could have a bot which released a new version of blackdoc pinned to each specific version of black. But the status quo seems OK too.

Ref https://github.com/pre-commit/pre-commit/issues/2082

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1404894283