issue_comments: 127507325

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/509#issuecomment-127507325 https://api.github.com/repos/pydata/xarray/issues/509 127507325 MDEyOklzc3VlQ29tbWVudDEyNzUwNzMyNQ== 1217238 2015-08-04T07:30:37Z 2015-08-04T07:30:37Z MEMBER

Decided to try reorganizing things and got sucked in, so I ended up making a PR to your fork with some tweaks: https://github.com/jhamman/xray/pull/1

This assuredly still needs more tests -- mostly to verify that every plot types ends up with consistent levels.

Here's my demo notebook: https://gist.github.com/shoyer/e6fafbc672021600d9f3

and a teaser:

The main difference in functionality is in my PR is that vmin and vmax cannot be set independently of levels, if levels is provided as a list. That seemed a little too flexible, and this way we can get a consistent result across all four plot types. Are there any cases where you would want to set vmin/vmax to something other than the first and last levels?

Also, I entirely replaced the levels calculation in contour/contourf with our calculated levels instead of merely trying to replicate it. That ensures things are guaranteed to be exactly identical across all plot types.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   98629509