issue_comments: 127357707

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/509#issuecomment-127357707 https://api.github.com/repos/pydata/xarray/issues/509 127357707 MDEyOklzc3VlQ29tbWVudDEyNzM1NzcwNw== 2443309 2015-08-03T18:14:10Z 2015-08-03T18:14:10Z MEMBER

The logic for inferring the extend keyword argument needs to be updated to handle levels:

How do you want to handle this? Options for when levels is provided and extend == None: 1. Don't extend. This will result in data outside the range of levels being masked out, 2. Extend if the min/max of the data exceed the range of levels, or 3. Require extend to be specified when levels is provided.

I will add the MaxNLocator ticker for integer levels. I agree this is the way to go.

I think this logic will also help address your 4th point:

...contourf currently crashes if you supply levels as an integer. This should be fixed, probably by converting levels into a 1d array / list if they are supplied as an integer before passing it into contourf. This would actually be more broadly useful, because currently there is no way to supply a non-default integer number of levels with contourf -- matplotlb appears to only expose the N argument when it is used positionally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   98629509