issue_comments: 127163088

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/509#issuecomment-127163088 https://api.github.com/repos/pydata/xarray/issues/509 127163088 MDEyOklzc3VlQ29tbWVudDEyNzE2MzA4OA== 1217238 2015-08-03T08:29:34Z 2015-08-03T08:32:11Z MEMBER

Some feedback: 1. matplotlib seems to have nice heuristics for picking level splits with contour plots. I wonder if it would be feasible to copy that logic here when setting our own discrete levels? Compare: ds.t2m[3].plot(levels=6) vs ds.t2m[3].plot.contourf() 2. The logic for inferring the extend keyword argument needs to be updated to handle levels: ds.t2m[3].plot(robust=True, levels=[200, 250, 260, 270, 280, 290, 350])

3.imshow, pcolormesh and contourf seem to deal with an explicit list of levels the exact same way. That's a relief. The plots look exactly the same. 4. As you noted, contourf currently crashes if you supply levels as an integer. This should be fixed, probably by converting levels into a 1d array / list if they are supplied as an integer before passing it into contourf. This would actually be more broadly useful, because currently there is no way to supply a non-default integer number of levels with contourf -- matplotlb appears to only expose the N argument when it is used positionally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   98629509