home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1266702407

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6795#issuecomment-1266702407 https://api.github.com/repos/pydata/xarray/issues/6795 1266702407 IC_kwDOAMm_X85LgFhH 14808389 2022-10-04T09:59:29Z 2022-10-04T15:28:25Z MEMBER

not really, I wanted to wait until set_xindex was in main (the PR has been merged last week) and have not looked at it since.

Edit: we don't yet have tests, though

There's two issues left that might need a bit of discussion: in 8f21df3 I skipped displaying default PandasIndex instances because that's basically redundant with the * on coordinates (and it would have required me to update a lot of doctests, which will probably make this a breaking change). If we decide to revert that, should we mark every coordinate with an index with a *?

Another proposal we had was to replace the "dimensions without coordinates" line with a "coordinates without index" line. @benbovy, this might be a misunderstanding on my part, but I thought "dimension coordinates" (and in particular their indexes) are still used for alignment? If so, I think we might need both lines.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1306887842
Powered by Datasette · Queries took 79.586ms · About: xarray-datasette