home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1262579935

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7098#issuecomment-1262579935 https://api.github.com/repos/pydata/xarray/issues/7098 1262579935 IC_kwDOAMm_X85LQXDf 35968931 2022-09-29T17:20:48Z 2022-09-29T17:20:48Z MEMBER

It's already perfectly covered by the testsuite.

Okay great, but then why are these tests failing for you (locally?) and not in our CI runs? (Our main branch just passed all automated tests just now.) Do you have a different version of some package that we aren't testing against?

I'm asking because if our current CI test runs don't reproduce this error, then we (a) have no way to check that your change fixed the error and (b) will not know if some regression causes this error to resurface in future. Standard practice would be to raise an issue that demonstrates the problem, then link the fix PR to that issue.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1389176083
Powered by Datasette · Queries took 80.201ms · About: xarray-datasette