home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1261491296

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6726#issuecomment-1261491296 https://api.github.com/repos/pydata/xarray/issues/6726 1261491296 IC_kwDOAMm_X85LMNRg 43316012 2022-09-28T21:37:30Z 2022-09-28T21:38:37Z COLLABORATOR

I just checked, many backends are importing their external dependencies at module level with a try-except block. This could be replaced by importlib.util.find_spec.

However, many backends also check for ImportErrors (not ModuleNotFoundError) that occur when a library is not correctly installed. I am not sure if in this case the backend should simply be disabled like it is now (At least cfgrib is raising a warning instead)? Would it be a problem if this error is only appearing when actually trying to open a file? If that is the case, we could move to lazy external lib loading for the backends.

Not sure how much it actually saves, but should be ~0.2s (at least on my machine, but depends on the number of intalled backends, the fewer are installed the faster the import should be).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1284475176
Powered by Datasette · Queries took 3.708ms · About: xarray-datasette