home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1257271454

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7052#issuecomment-1257271454 https://api.github.com/repos/pydata/xarray/issues/7052 1257271454 IC_kwDOAMm_X85K8HCe 43316012 2022-09-25T20:19:16Z 2022-09-25T20:19:16Z COLLABORATOR

One point aside — when this is done, we may be able to turn on mypy's strict mode, at least for the tests path, so then tests always need annotations, and our annotations get tested.

(for context, a year ago or so we found some of them were wrong, but weren't being tested, because -> None wasn't in the tests)

I think there are still many untyped areas, especially internal stuff. But we can give it a try and see where it collapses :)

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1377128403
Powered by Datasette · Queries took 0.796ms · About: xarray-datasette