home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1256702326

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7052#issuecomment-1256702326 https://api.github.com/repos/pydata/xarray/issues/7052 1256702326 IC_kwDOAMm_X85K58F2 43316012 2022-09-23T21:39:10Z 2022-09-23T21:39:10Z COLLABORATOR

Wow, to fix the overloads I had to copy-paste the complete function signature for each overload and again for the accessor methods. This leads to a massive overhead which I assume the initial author wanted to prevent by using the decorators in the first place...

Are there any objections to leaving it like this? We could also deviate from the approach of adding typing inline and use stub files (.pyi like in typed_ops).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1377128403
Powered by Datasette · Queries took 0.762ms · About: xarray-datasette