issue_comments: 1251142486

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6908#issuecomment-1251142486 https://api.github.com/repos/pydata/xarray/issues/6908 1251142486 IC_kwDOAMm_X85KkutW 35968931 2022-09-19T14:58:29Z 2022-09-19T14:58:55Z MEMBER

@Zac-HD if I could request one more review please! The two remaining problems for me are:

1) How should we alter the API of datasets to make it easier to construct Dataset objects containing duck-typed arrays (see https://github.com/pydata/xarray/pull/6908#discussion_r974066789) 2) Why does the example generation performance seem to have gotten worse? :confused: I added what I thought were small refactors (e.g. _sizes_from_dim_names) which may somehow be related, but I'm not sure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1336119080