issue_comments: 125068381

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/495#issuecomment-125068381 https://api.github.com/repos/pydata/xarray/issues/495 125068381 MDEyOklzc3VlQ29tbWVudDEyNTA2ODM4MQ== 1217238 2015-07-27T02:55:50Z 2015-07-27T02:55:50Z MEMBER

This looks very nice -- thanks for putting together the PR!

allow numeric axis instead of dim for DataArray objects.

I wouldn't bother with this. It's not so elegant, and dim already takes care of all the desired functionality.

allow specifying the new coordinate array explicitly via a coord kwarg instead of just taking the coordinate values of the upper bounds.

I wouldn't allow full control here, but maybe a keyword argument for choosing whether to take the "lower", "upper" or "mean" labels would be appropriate.

Actually, the current implementation leads to 0.0 for arrays inside a Dataset which don't have dim as a dimension. I personally would find it more intuitive if those arrays would not be touched at all.

I agree. It would be better to skip those variables entirely, like the current behavior for aggregation functions like mean.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   97237275