issue_comments: 1211580601

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4972#issuecomment-1211580601 https://api.github.com/repos/pydata/xarray/issues/4972 1211580601 IC_kwDOAMm_X85IN0C5 35968931 2022-08-11T06:00:29Z 2022-08-11T06:00:29Z MEMBER

Q: Shouldn't the base classes live in xarray.testing rather than xarray.tests?

Another Q on a similar note: Are we planning to eventually publicly expose the (awesome btw) strategies that you've built here @keewis ? They could be very useful for testing other parts of xarray.

We could also make this PR much more incremental by splitting it into 2, or even 3 separate PRs: 1) strategies, to live somewhere like xarray.testing.strategies and eventually be made public 2) duck array base classes to inherit from, to live somewhere like xarray.testing.duckarrays 3) specific tests for pint/sparse, to live in our own test suite for now but moved out eventually.

The advantage of that would be that (1) & (2) can move forwards without requiring all the tests in (3) to pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   818059250