home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1204316906

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6813#issuecomment-1204316906 https://api.github.com/repos/pydata/xarray/issues/6813 1204316906 IC_kwDOAMm_X85HyGrq 1828519 2022-08-03T18:17:41Z 2022-08-03T18:17:41Z CONTRIBUTOR

I am not certain whether seeking/reading from the same file in multiple places might have unforeseen consequences, such as when doing open_dataset in multiple threads.

Oh duh, that's a good point. So it might be fine dask-wise if the assumption is that open_dataset is called in the main thread and then dask is used to do computations on the arrays later on. If we're talking regular Python Threads or dask delayed functions that are calling open_dataset on the same file-like object (that was passed to the worker function) then it would cause issues. Possibly rare case, but still probably something that xarray wants to support.

Yeah I thought the .read/.write omission from the IOBase class was odd too. Just wanted to point out that the if block is using .read but IOBase is not guaranteed to have .read.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1310058435
Powered by Datasette · Queries took 1.043ms · About: xarray-datasette