issue_comments: 1189151229

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2304#issuecomment-1189151229 https://api.github.com/repos/pydata/xarray/issues/2304 1189151229 IC_kwDOAMm_X85G4QH9 2448579 2022-07-19T14:49:34Z 2022-07-19T14:49:34Z MEMBER

We'd happily take a PR implementing the suggestion above following CF-conventions.

Looking at the dtype for add_offset and scale_factor does seem like a much cleaner way to handle this issue. I think we should give that a try!

IIUC the change should be made here in _choose_float_dtype: https://github.com/pydata/xarray/blob/392a61484e80e6ccfd5774b68be51578077d4292/xarray/coding/variables.py#L266-L283

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   343659822