home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1188483366

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4972#issuecomment-1188483366 https://api.github.com/repos/pydata/xarray/issues/4972 1188483366 IC_kwDOAMm_X85G1tEm 35968931 2022-07-19T01:03:23Z 2022-07-19T01:03:23Z MEMBER

Can we xfail these new tests and merge for now? As long as tests/test_sparse.py still passes, there are no issues, correct?

Yeah we now have another array type to consider testing, so I'm also in favour of merging now with passing tests for pint, and un-xfailing tests for other array types (i.e. sparse) in a later PR.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  818059250
Powered by Datasette · Queries took 1.088ms · About: xarray-datasette