issue_comments: 1154368202

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6665#issuecomment-1154368202 https://api.github.com/repos/pydata/xarray/issues/6665 1154368202 IC_kwDOAMm_X85EzkLK 5635139 2022-06-13T19:54:41Z 2022-06-13T19:54:41Z MEMBER

Yes great, let's merge this.

And then open another issue on how to procede with rename in light of the index refactor? Great!

Then two main options I see for synthesizing the vars issues: - rename operates on DataArray as described in https://github.com/pydata/xarray/pull/6665#issuecomment-1150810485. Generally I'm less keen on "different types have different semantics", and here a positional arg would mean a DataArray rename, and kwarg would mean var rename. But it does work locally to DataArray quite well. - rename only exists on DataArrays for the name of the DataArray, and we use rename_vars & rename_dims for both DataArrays & Datasets. So Dataset.rename is soft-deprecated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1261153511