issue_comments: 1152520663

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6685#issuecomment-1152520663 https://api.github.com/repos/pydata/xarray/issues/6685 1152520663 IC_kwDOAMm_X85EshHX 5635139 2022-06-10T16:09:57Z 2022-06-10T16:09:57Z MEMBER

Great improvements @soxofaan !

Side question: is it intentional to use dict(space=0) in dimension name based indexing instead of {"space": 0} (which is shorter and probably more widely known) everywhere?

Personally I find it easier to read; partly because the kwargs are cleaner than the dict syntax. I think others have said that they are more ambivalent. I certainly don't have a strong view, and on the "intro" pages we should use whatever is most understandable to a new user, so happy to take a PR to change those.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1267307887