home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1132147701

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6142#issuecomment-1132147701 https://api.github.com/repos/pydata/xarray/issues/6142 1132147701 IC_kwDOAMm_X85DezP1 43316012 2022-05-19T20:05:43Z 2022-05-19T20:05:43Z COLLABORATOR

But I'm also not sure we lose anything with Mapping[Any, foo] — the key needs to be Hashable anyway. I don't have a strong objection, but do we gain anything?

Wow, totally forgot about this. Then you are right, Any as key is totally ok.

Although if I am not mistaken, one could define a custom Mapping class that allows non-hashable keys, this is quite a niche use case and there are more urgent things to type, like this issue.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1094725752
Powered by Datasette · Queries took 0.694ms · About: xarray-datasette