issue_comments: 1124053990

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6566#issuecomment-1124053990 https://api.github.com/repos/pydata/xarray/issues/6566 1124053990 IC_kwDOAMm_X85C_7Pm 35968931 2022-05-11T17:31:55Z 2022-05-11T17:31:55Z MEMBER

We discussed this in the team meeting today.

Questions:

  1. How should I test this?

I've added a test which simply counts the number of nodes in the dask graph and checks that it is smaller when inline_array is True.

  1. Should it default to False or True?

We decided False for now, and maybe switch it in a future PR

  1. inline_array or inline? (inline_array doesn't really make sense for open_dataset, which . creates multiple arrays)

I'll just leave it as inline_array for now.

I think this can be merged?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1223270563