issue_comments: 1120217016

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6578#issuecomment-1120217016 https://api.github.com/repos/pydata/xarray/issues/6578 1120217016 IC_kwDOAMm_X85CxSe4 14808389 2022-05-07T14:12:25Z 2022-05-07T22:39:35Z MEMBER

my guess is that this is due to the merge of dask/dask#8674 and a follow-up PR, which changed dask.is_dask_collection from python def is_dask_collection(x) try: return x.__dask_graph__() is not None except (AttributeError, TypeError): return False to python def is_dask_collection(x): return hasattr(x, "__dask_graph__") and callable(x.__dask_graph__) and inspect.isclass(x)

This means that it never actually calls __dask_graph__, which is not ideal because xarray objects return None if the wrapped array is not a dask collection.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1228474784