issue_comments: 1114002143

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6548#issuecomment-1114002143 https://api.github.com/repos/pydata/xarray/issues/6548 1114002143 IC_kwDOAMm_X85CZlLf 43316012 2022-04-30T14:57:58Z 2022-05-01T11:50:12Z COLLABORATOR

Several open points still:

  1. [x] Unittests for datetime values are failing, I might need some help with that since I have no idea what this means for polynomials.
  2. [x] Algorithm should work also with Datasets (any combination of DataArray and Dataset for coord and coeffs inputs). Still needs to be checked and tested (How does one define typing for such cases? I.e. DataArray + Dataset -> Dataset but DataArray + DataArray -> DataArray?)
  3. [x] It uses Horners method instead of Vandermonde matrix, should be faster and consume less memory (unless the overhead of sorting index, isel etc. is too large). Maybe some performance comparisons should be done.
  4. [ ] Instead of coord the input should simply be called x or similar, however this would break backwards compatibility, so maybe we just leave it.
  5. [x] I had to add a copy(deep=True) since the broadcast returned a read-only DataArray. Any better ideas?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1221848774